https://bugzilla.redhat.com/show_bug.cgi?id=2373136
--- Comment #1 from Neal Gompa <[email protected]> --- Initial spec review: > Version: 4.0.2^1.git69922bde This should probably be "4.0.2^1.git%{shortcommit}" You might want to macroize the "1" so it's easy to spot to update. > Release: 0 This needs to be set to "1%{?dist}" Cf. https://docs.fedoraproject.org/en-US/packaging-guidelines/DistTag/ > Group: Development/Libraries/C and C++ This should be dropped, we don't use the Group tag at all. > Source: > https://github.com/Aetf/libtsm/archive/%{commit}/%{name}-%{shortcommit}.tar.gz This can be simplified to "%{url}/archive/%{commit}/%{name}-%{shortcommit}.tar.gz" > %package -n %{lname} We don't typically do this in Fedora, this can be folded back into the main "libtsm" package. > %post -n %{lname} -p /sbin/ldconfig > %postun -n %{lname} -p /sbin/ldconfig This is useless in Fedora since Fedora 28 / RHEL 8. Cf. https://fedoraproject.org/wiki/Changes/Removing_ldconfig_scriptlets -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2373136 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202373136%23c1 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
