https://bugzilla.redhat.com/show_bug.cgi?id=2371328
Bug ID: 2371328
Summary: Review Request: mygui - Unretire mygui with newest
version for f41+
Product: Fedora
Version: rawhide
Hardware: All
OS: Linux
Status: NEW
Component: Package Review
Severity: medium
Assignee: [email protected]
Reporter: [email protected]
QA Contact: [email protected]
CC: [email protected]
Target Milestone: ---
Classification: Fedora
Spec URL:
https://github.com/Chapien/mygui-copr/raw/refs/heads/main/sources/mygui.spec
SRPM URL:
https://github.com/Chapien/mygui-copr/raw/refs/heads/main/mygui-3.4.3-1.fc42.src.rpm
Description: Upstream: https://github.com/MyGUI/mygui
This package was maintained until around 2020, at which point it was retired. I
am attempting to package openMW, which relies on MyGUI being available. MyGUI
has received a few updates since it was retired, so I updated the spec file
accordingly. It now uses OpenGL as a backend instead of OGRE. I've removed the
demos from the repo for now, as I am unsure if they work without using OGRE,
but I've tested the tools and they work as expected. I am unsure of all the
build dependencies for openGL projects, so some of them may be unnecessary --
please let me know. This is my first review request, so I am very much open to
feedback -- but I've run fedora-review, and the issues it has seem like false
positives.
From fedora-review:
Issues:
=======
- Header files in -devel subpackage, if present.
Note: mygui-tools :
/usr/share/MYGUI/Media/Tools/LayoutEditor/CodeTemplates/BaseLayoutTemplate.h
See: https://docs.fedoraproject.org/en-US/packaging-
guidelines/#_devel_packages
- If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %license.
Note: License file _licensing.html is not marked as %license
See: https://docs.fedoraproject.org/en-US/packaging-
guidelines/LicensingGuidelines/#_license_text
- Package does not use a name that already exists.
Note: A package with this name already exists. Please check
https://src.fedoraproject.org/rpms/mygui
See: https://docs.fedoraproject.org/en-US/packaging-
guidelines/Naming/#_conflicting_package_names
For the first, the header file is part of the sample code, and as such I don't
believe it should be in the includedir. _licensing.html is from the doxygen
docs; COPYING.MIT is the actual license and is placed appropriately. Finally,
the last one is obvious; I am attempting to unretire an existing package, so
the name does of course exist.
Fedora Account System Username: chapien
Since it might be relevant, here is the copr repo link:
https://copr.fedorainfracloud.org/coprs/chapien/mygui/
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2371328
Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202371328%23c0
--
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it:
https://pagure.io/fedora-infrastructure/new_issue
