https://bugzilla.redhat.com/show_bug.cgi?id=2366921
--- Comment #11 from Ben Beasley <[email protected]> --- (In reply to Jannik Müller from comment #8) > I tried as far as I could, unforunately Dragonbox is from the upstream > source. The developer of Dragonbox hasn't released a new update in the last > 3 years while the upstream source has been edited 7 months ago. glaze uses > the version from 7 months ago, therefore the system library is missing > definitions that are required for glaze. This seems reasonable enough. You should write a spec-file comment explaining that, and (in the -devel subpackage), add: # Blah, blah, my explanation here Provides: bundled(dragonbox) = 1.1.3^20241028git6c7c925 > I was able to include xxhash64ct and fast_float as system libraries. Awesome! Although I played with this a little more, and I think I made an error in my suggestion: namespace glz::fast_float = fast_float; should have been namespace glz { namespace fast_float = ::fast_float; } > Even without the above changed, enabling tests causes the build to fail: I fiddled with this a bit. I got as far as adding: # For tests (header-only): BuildRequires: eigen3-static # Missing -static virtual Provides for header-only BuildRequires: asio-devel …and then you can pass the following options to CMake to deal with the FetchContent invocations: -DFETCHCONTENT_FULLY_DISCONNECTED:BOOL=TRUE \ -DFETCHCONTENT_TRY_FIND_PACKAGE_MODE=ALWAYS I could not unbundle ut because Fedora’s ut package is based on https://github.com/boost-ext/ut, provides cmake(ut), and installs /usr/include/boost/ut.hpp. This package needs https://github.com/openalgz/ut, which should provide cmake(ut::ut) and be installed as /usr/include/ut/ut.hpp. They are not the same library. To unbundle ut, another new package would be required, maybe named openalgz-ut. > It seems to be that the test uses a template which creates a realization > that is not allowed in the cpp library. I would create an issue on upstream, > but would suggest disabling the tests that are defective until upstream > fixes it. I need the library to update Hyprland. Hyprland doesn't seem to > use the broken features that are used in the test. This seems likely, but I’m not sure how you are dealing with the bundled (openalgz-ut) and I don’t want to re-invent the wheel, so I cannot easily reproduce it and play with it myself at the moment. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2366921 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202366921%23c11 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
