https://bugzilla.redhat.com/show_bug.cgi?id=2354054

Miro Hrončok <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]



--- Comment #16 from Miro Hrončok <[email protected]> ---
The package BuildRequires coverage and pytest-cov and should, not:
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_linters


  # RHEL9 doesn't have nose, and it won't be added to EPEL9 because it's
  # abandoned upstream (and deprecated in Fedora).
  # https://bugzilla.redhat.com/show_bug.cgi?id=2041068
  %if %{undefined el9}
  %bcond_without  tests
  %endif

Is this comment still accurate? I don't see nose being used at all.


  PYTHONPATH="%{buildroot}/%{python3_sitelib}"
  %tox -e docs

Is this PYTHONPATH needed? It does not affect tox (it is not exported) and %tox
macro sets PYTHONPATH for itself.

  # Disable setting up dns (we have no /etc/resolv.conf in mock

Missing )

  %pyproject_check_import -t

Is the -t option necessary?


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2354054

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202354054%23c16

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to