https://bugzilla.redhat.com/show_bug.cgi?id=2366587



--- Comment #6 from Robert Scheck <[email protected]> ---
Spec URL: https://labs.linuxnetz.de/bugzilla/ipv6toolkit.spec
SRPM URL: https://labs.linuxnetz.de/bugzilla/ipv6toolkit-2.2-2.src.rpm


1. License tag has been corrected and a breakdown is in the spec file, too.
However, there is no "RealNetworks Public Source License" involved, the license
check somehow gets (wrongly) triggered by the word "real" in the man page.


2. The missing-call-to-setgroups-before-setuid error is a detection mistake in
rpmlint:

$ grep -r -E set[ug]id ipv6toolkit-2.2
ipv6toolkit-2.2/tools/libipv6.c:       If the real UID is not root, we setuid()
and setgid() to that user and group, releasing superuser
ipv6toolkit-2.2/tools/libipv6.c:       privileges. Otherwise, if the real UID
is 0, we try to setuid() to "nobody", releasing superuser
ipv6toolkit-2.2/tools/libipv6.c:        if (setgid(rgid) == -1) {
ipv6toolkit-2.2/tools/libipv6.c:        if (setuid(ruid) == -1) {
ipv6toolkit-2.2/tools/libipv6.c:            if (setgid(pwdptr->pw_gid) == -1) {
ipv6toolkit-2.2/tools/libipv6.c:            if (setuid(pwdptr->pw_uid) == -1) {
$ 

See also:
https://github.com/fgont/ipv6toolkit/blob/master/tools/libipv6.c#L1841

From my point of view rpmlint gets confused by the if/else conditions and
matches the middle part (setuid() in if and setgid() in else).


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2366587

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202366587%23c6

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to