https://bugzilla.redhat.com/show_bug.cgi?id=2365640
--- Comment #7 from Stephen Gallagher <[email protected]> --- (In reply to Jakub Kadlčík from comment #6) > Thank you for the package Stephen, > > > Issues: > > ======= > > - Package must not depend on deprecated() packages. > > Note: python3-toml is deprecated, you must not depend on it. > > See: https://docs.fedoraproject.org/en-US/packaging- > > guidelines/deprecating-packages/ > > This is a test-only dependency, behind a conditional, and with a proposed > patch to the upstream. Let's not block the review by this. > I think that was due to the other issue below. > > > W: summary-ended-with-dot An efficient implementation of a rate limiter for > > asyncio. > > E: description-line-too-long This project implements the Leaky bucket > > algorithm, giving you precise control over the rate a code section can be > > entered. > > Rpmlint found these two easy-to-fix issues. Can be done post-review. > > > > BuildRequires: python3-toml > > %if 0%{?rhel} < 10 > > BuildRequires: python3-toml > > %endif # rhel9 > > Should there be the first python3-toml? Also, the %endif comment should > probably say rhel10 > I put that there while I was testing and forgot to remove it before pushing the latest spec/SRPM. I just re-tested without it to make sure I didn't get false successes earlier. The `rhel9` comment there was intentional; the test is for "less than RHEL 10". That said, I removed it because the version of RPM on RHEL 9 apparently doesn't accept it. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2365640 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202365640%23c7 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
