https://bugzilla.redhat.com/show_bug.cgi?id=2353918
--- Comment #25 from Jonny Heggheim <[email protected]> --- (In reply to Srisharan V S from comment #20) > How should I provide the document link for tui.patch? > Other stuff have ben fixed It depends on the patch. Did you write it? Is it for Fedora only? If not, have it been reported upstream? If someone have reported upstream; include a link to the issue tracker, etc. These guidelines are good https://docs.fedoraproject.org/en-US/packaging-guidelines/PatchUpstreamStatus/ Here is an example from source-foundry-hack-fonts.spec: # https://github.com/source-foundry/Hack/pull/644 # Use systemId urn:fontconfig:fonts.dtd to reference the fonts.dtd type defintion #644 Patch0: https://github.com/source-foundry/Hack/pull/644.patch From your spec file: Patch0: tui.patch #The Patch contains the Updated instructions for the variant executables - https://invent.kde.org/joaotgouveia/mankalaengine/-/merge_requests/10 Looking at the merge requires 10, the title "Installing Tui binaries" would probably be a good comment. Why is the merge request 10 different from the patch? As a side note: I would remove the "The Patch contains the" part of the sentence. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2353918 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202353918%23c25 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
