https://bugzilla.redhat.com/show_bug.cgi?id=2358822

Pavol Sloboda <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |needinfo?([email protected]
                   |                            |om)



--- Comment #10 from Pavol Sloboda <[email protected]> ---
Spec URL:
https://download.copr.fedorainfracloud.org/results/psloboda/credcheck/fedora-rawhide-x86_64/08906127-credcheck/credcheck.spec
SRPM ULR:
https://download.copr.fedorainfracloud.org/results/psloboda/credcheck/fedora-rawhide-x86_64/08906127-credcheck/credcheck-3.0-1.fc43.src.rpm

> You should preserve the original timestamp. See 
> https://docs.fedoraproject.org/en-US/packaging-guidelines/#_timestamps
I recommend using `cp -a` or `cp -p`.

> The selinux part should be improved. You do not have `Requires` and you do 
> not relabel files that changed context. I wanted to point you to relevant 
> documentation, but to my surprise there is none.

Thank you, I fixed it in this version.

> As you are not packager yet, you should follow 
> https://docs.fedoraproject.org/en-US/package-maintainers/Package_Review_Process/#review_process
>  and your first review should block FE-NEEDSPONSOR tracking bug. (I done this 
> for you now).

Thanks, didn't notice it there.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2358822

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202358822%23c10

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to