https://bugzilla.redhat.com/show_bug.cgi?id=2354812
--- Comment #4 from Benson Muite <[email protected]> --- (In reply to Simone Caronni from comment #3) > Some comments: > > > BuildRequires: libjpeg-turbo-devel > > BuildRequires: libpng-devel > > BuildRequires: libwebp-devel > > BuildRequires: mesa-libGL-devel > > BuildRequires: rapidjson-devel > > BuildRequires: SDL2-devel > > BuildRequires: meson > > BuildRequires: ninja-build > > Meson looks for some of these dependencies using pkgconfig, so for those > please update the build requirements to use the pkgconfig format. Example: > > BuildRequires: pkgconfig(libturbojpeg) > BuildRequires: pkgconfig(libpng) > BuildRequires: pkgconfig(libwebp) > BuildRequires: pkgconfig(sdl2) Done. > > > # Modifications do not allow for use of packaged rapidjson > > # https://github.com/thorvg/thorvg/issues/3358 > > Provides: bundled(rapidjson) > > I think this is just a leftover to remove, as you require rapidjson as > BuildRequires and you are also removing src/loaders/lottie/rapidjson in the > %prep section. That package will not build, removing the files was an error. > > > %global _description %{expand: > > [..] > > %description %_description > > You can avoid using the macro, you are calling the block of description just > once, it's more readable if you put the description under %description > directly. > Done. spec: https://fed500.fedorapeople.org/thorvg.spec srpm: https://fed500.fedorapeople.org/thorvg-0.15.11-1.fc43.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2354812 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202354812%23c4 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
