https://bugzilla.redhat.com/show_bug.cgi?id=2353284
Davide Cavalca <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+ CC| |[email protected] Assignee|[email protected] |[email protected] Status|NEW |POST --- Comment #3 from Davide Cavalca <[email protected]> --- This is generally fine, but I would recommend updating the spec to use modern macros, fixing indentation and dropping the license audit comment. Also on > install -D -m 644 SystemVersion.plist > $RPM_BUILD_ROOT/boot/efi/System/Library/CoreServices/SystemVersion.plist please use -p to preserve timestamps, which will help with reproducibility. None of these are really blockers, so I'm approving as-is, but please fix them on import. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2353284 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202353284%23c3 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
