https://bugzilla.redhat.com/show_bug.cgi?id=2348850
--- Comment #18 from Sayan <[email protected]> --- @[email protected] I have modified the spec file as per your comments and have added inline comments for the change details. Please let me know if it looks good, Thanks. Release: 1%{?dist} - this can be %autorelease -- Added autorelease Summary: Recast Navigation is a state of the art navigation system for games and 3D applications. - rmplint complains this is tool long, I use the 'About' field in github, so can change to. - 'Industry-standard navigation-mesh toolset for games' -- Condensed the summary License: zlib - license is tricky, look - https://docs.fedoraproject.org/en-US/legal/allowed-licenses/ - should be Zlib - the license check flag a few more licenses, if the files are not really used, rm them in the %prep step. - if they are needed, License: needs to be updated, and breakdown of the which files use which -- Validated the license from the allowed list and updated to: Zlib AND MIT AND BSL-1.0 AND Apache-2.0 URL: https://github.com/recastnavigation/recastnavigation Source0: https://github.com/recastnavigation/recastnavigation/archive/refs/tags/v%{version}.tar.gz - Source0: should be prefixed with %{url}, and the 'ref/tags' may not be needed -- Modified to: %{url}/archive/v%{version}.tar.gz Requires: libdecor-devel - Should not need this, rpmlint complains. -- Removed it. # Disable debug source package to avoid issues with empty debugsourcefiles.list %define debug_package %{nil} - rpmlint complains about unstripped files, so something is wrong, generally, we want the libraries to be build with some level debugging for the user. -- I couldn't get past it, so I kept it. %{_bindir}/Meshes/dungeon.obj %{_bindir}/Meshes/nav_test.obj %{_bindir}/Meshes/undulating.obj - These were in the tarball, it looks like the upstream was sloppy, review the RecastDemo/Bin from the tarball, and remove all/most of it in %prep -- This is required by the binary RecastDemo , since its just a demo moved to /var/lib/recastnavigation %{_prefix}/bin/DroidSans.ttf - this is data, not a binary, so it needs to go somewhere like %_datadir/%{name} - likely this means any binary that needs to use it needs to be changed to look for the new location -- same as above. %{_bindir}/TestCases/movement_test.txt %{_bindir}/TestCases/nav_mesh_test.txt %{_bindir}/TestCases/raycast_test.txt - Similar, but maybe there needs to be an optional -test subpackage - i would like a %check to make sure it is working. -- Added %ctest, removed the test cases as there is already a Test binary which run checks. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2348850 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202348850%23c18 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
