https://bugzilla.redhat.com/show_bug.cgi?id=2348850

[email protected] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|[email protected]    |[email protected]
                 CC|                            |[email protected]



--- Comment #4 from [email protected] ---
mock is failing for me, so i could not run a full fedora-review.

I added the sed line to fix, and removed setting cmake min on the command line

%build/install should be using the %cmake macros
https://docs.fedoraproject.org/en-US/packaging-guidelines/CMake/

And the libraries should not be static.


sed -i -e 's@cmake_minimum_required(VERSION 3.1)@cmake_minimum_required(VERSION
3.5)@' CMakeLists.txt

%build
mkdir -p build
cd build
cmake .. -DCMAKE_INSTALL_PREFIX=%{_prefix} -DCMAKE_BUILD_TYPE=Release
make %{?_smp_mflags}

%install
mkdir -p %{buildroot}%{_prefix}/lib
mkdir -p %{buildroot}%{_prefix}/include/recastnavigation


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2348850

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202348850%23c4

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to