https://bugzilla.redhat.com/show_bug.cgi?id=2334700
--- Comment #5 from Simone Caronni <[email protected]> --- (In reply to Jonathan Steffan from comment #4) > Issues: > ======= > - Python packages must not contain %{pythonX_site(lib|arch)}/* in %files > Note: Package contains %{pythonX_site(lib|arch)}/* in %files > See: https://pagure.io/packaging-committee/issue/782 > > %{python3_sitearch}/* needs to be updated to only define files for this > package or use the macros. Fixed by listing files and folders. As written in the SPEC file comments, we can't use the %pyproject_save_files macro. > [!]: Development (unversioned) .so files in -devel subpackage, if present. > Note: Unversioned so-files in private %_libdir subdirectory (see > attachment). Verify they are not in ld path. > > We are likely going to need to patch to add a SONAME and punt upstream. This is not an unversioned library, this is the Python filter library and it's correct: $ rpm -qpl python3-cnkalman-0.1^20230315gitf0c11f7-1.fc41.x86_64.rpm | grep \.so /usr/lib64/python3.13/site-packages/filter.cpython-313-x86_64-linux-gnu.so > [!]: License file installed when any subpackage combination is installed. > > LICENSE is not installed when python3-%{name} is installed. This is not correct, as the Python package depends on the library file due to the Python filter library: $ rpm -qp --requires python3-cnkalman-0.1^20230315gitf0c11f7-1.fc41.x86_64.rpm | grep libcnkalman libcnkalman.so.0()(64bit) > [!]: Package is not known to require an ExcludeArch tag. > [!]: Package should compile and build into binary rpms on all supported > architectures. > > Due to ExcludeArch for 32bit on python3-symengine we will need to do that in > this package too. > > https://koji.fedoraproject.org/koji/taskinfo?taskID=127468995 Fixed. > [!]: Package complies to the Packaging Guidelines > > Unversioned SONAME in the loader path without a clear exception. > %{_libdir}/lib%{name}.so.* included in both the main file and the -devel > package. This is not the case, I think the output is from an earlier version of the spec file: $ rpm -qpl 'cnkalman-devel-0.1^20230315gitf0c11f7-1.fc41.x86_64.rpm' | grep lib64 /usr/lib64/libcnkalman.so /usr/lib64/pkgconfig/cnkalman.pc $ rpm -qpl 'cnkalman-0.1^20230315gitf0c11f7-1.fc41.x86_64.rpm' | grep lib64 /usr/lib64/libcnkalman.so.0 > [!]: Package meets the Packaging Guidelines::Python > > Need to clean up the %files for this. Fixed in the first step. > [!]: %check is present and all tests pass. > > There are tests, we should try to run them. Struggling a bit with tests/TestKalmanModels.cc, I can't link properly cnmatrix for the cnSetZero function. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2334700 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202334700%23c5 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
