https://bugzilla.redhat.com/show_bug.cgi?id=2279547

Fabio Valentini <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[email protected]    |[email protected]
              Flags|                            |fedora-review?
             Status|NEW                         |ASSIGNED
                 CC|                            |[email protected]



--- Comment #6 from Fabio Valentini <[email protected]> ---
> # * can't seem to compile them :/
> %bcond_with check

What is this supposed to mean? Please elaborate in more detail than "meh, no".
:)

Other than that, package looks pretty good to me.
Though there are some files that you might want to exclude from the -devel
package:

- contrib: VS Code plugin?
- examples/: just a python script that calls sqlx-cli, which is not included in
the package?
- gen-changelog.sh: doesn't see useful for packaging
- rust-toolchain.toml: not useful for packaging
- tests/ directory in general: lots of scripts (bash, python), certificates,
etc.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2279547

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202279547%23c6

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to