https://bugzilla.redhat.com/show_bug.cgi?id=2307815

Zbigniew JÄ™drzejewski-Szmek <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+
             Status|ASSIGNED                    |POST



--- Comment #18 from Zbigniew JÄ™drzejewski-Szmek <[email protected]> ---
Now it looks all good.

rpmlint:
tinyows.x86_64: W: no-manual-page-for-binary tinyows
tinyows.x86_64: W: no-documentation
tinyows.x86_64: W: files-duplicate /usr/share/tinyows/schema/LICENSE
/usr/share/licenses/tinyows/LICENSE

tinyows-doc.noarch: E: files-duplicated-waste 16728835                          
tinyows-doc.noarch: W: files-duplicate
/usr/share/doc/tinyows-doc/doxygen/ows__api_8h_a0a15f53f62900b330685e184da60e25e_cgraph.map
/usr/share/doc/tinyows-doc/doxygen/alist_8c_a0a15f53f62900b330685e184da60e25e_cgraph.map
 
tinyows-doc.noarch: W: files-duplicate
/usr/share/doc/tinyows-doc/doxygen/ows__api_8h_a0a15f53f62900b330685e184da60e25e_cgraph.md5
/usr/share/doc/tinyows-doc/doxygen/alist_8c_a0a15f53f62900b330685e184da60e25e_cgraph.md5
 
tinyows-doc.noarch: W: files-duplicate
/usr/share/doc/tinyows-doc/doxygen/ows__api_8h_a0a15f53f62900b330685e184da60e25e_cgraph.png
/usr/share/doc/tinyows-doc/doxygen/alist_8c_a0a15f53f62900b330685e184da60e25e_cgraph.png
 
tinyows-doc.noarch: W: files-duplicate
/usr/share/doc/tinyows-doc/doxygen/ows__api_8h_a19cbf414bb13aa9fb0aac2fd26d36cfc_cgraph.map
/usr/share/doc/tinyows-doc/doxygen/alist_8c_a19cbf414bb13aa9fb0aac2fd26d36cfc_cgraph.map
 
tinyows-doc.noarch: W: files-duplicate
/usr/share/doc/tinyows-doc/doxygen/ows__api_8h_a19cbf414bb13aa9fb0aac2fd26d36cfc_cgraph.md5
/usr/share/doc/tinyows-doc/doxygen/alist_8c_a19cbf414bb13aa9fb0aac2fd26d36cfc_cgraph.md5
 
tinyows-doc.noarch: W: files-duplicate
/usr/share/doc/tinyows-doc/doxygen/ows__api_8h_a19cbf414bb13aa9fb0aac2fd26d36cfc_cgraph.png
/usr/share/doc/tinyows-doc/doxygen/alist_8c_a19cbf414bb13aa9fb0aac2fd26d36cfc_cgraph.png
 
tinyows-doc.noarch: W: files-duplicate
/usr/share/doc/tinyows-doc/doxygen/ows__api_8h_a815b58142ab6406ce5312cf55e44fe23_cgraph.map
/usr/share/doc/tinyows-doc/doxygen/alist_8c_a815b58142ab6406ce5312cf55e44fe23_cgraph.map
 
...

I'm not sure what is going on here. I would expect that post-build scriptlets
automatically hardlink any repeated files.
Ah, no the hardlinking is only done for python pyc files, and not in general.

Please consider adding the following change:
diff --git tinyows.spec tinyows.spec
index e7d479fb24..fccbdcf4c2 100644
--- tinyows.spec
+++ tinyows.spec
@@ -73,7 +73,6 @@ sed -i -e
's|HTML_FOOTER|HTML_FOOTER=no_date_footer.html\n\#|g' doc/Doxyfile
 make doxygen

 %install
-
 install -d %{buildroot}%{_bindir}
 install -p -m 0755 tinyows %{buildroot}%{_bindir}/
 install -d %{buildroot}%{_datadir}/%{name}
@@ -83,6 +82,10 @@ install -p -m 0644 ms4w/apps/tinyows-svn/config.xml
%{buildroot}%{_sysconfdir}/%

 ln -s --relative %{buildroot}%{_sysconfdir}/%{name}/config.xml
%{buildroot}%{_datadir}/%{name}/

+mkdir -p %{buildroot}%{_pkgdocdir}
+cp -a doc/doxygen %{buildroot}%{_pkgdocdir}/
+hardlink --ignore-time --reflink=never %{buildroot}%{_pkgdocdir}/
+
 # NOTE(neil): 2024-08-25 tests require a postgres database running; unable to
run in check
 #
https://github.com/MapServer/tinyows/blob/f1dc7bc86fc4d69faddd79ed2804d98c11802ba8/.github/workflows/linux.sh#L19-L22
 %dnl %check
@@ -96,7 +99,7 @@ ln -s --relative
%{buildroot}%{_sysconfdir}/%{name}/config.xml %{buildroot}%{_da

 %files doc
 %doc README.md VERSION.md
-%doc doc/doxygen
+%doc %{_pkgdocdir}/doxygen

Package is APPROVED.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2307815

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202307815%23c18

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to