https://bugzilla.redhat.com/show_bug.cgi?id=2302674
--- Comment #9 from Javier Jardón <[email protected]> --- Hey Michael, sorry I missed your comments in here: > - Some of the build dependencies provide pkg-config files. In these cases, > using a pkg-config dependency is preferred over specifying the name of the > package. E.g. you can "BuildRequires: pkgconfig(cares)" rather than > "BuildRequires: c-ares-devel". This is not required, but good to do. I was actually wondering about this; it should be fixed now > - Please use "%autosetup -p1" (otherwise, anybody trying to add patches in > the future will be sad) Done! > - Package depends on ninja-build but doesn't pass -GNinja to %cmake_build, so > looks like it builds with make? Can the BuildRequires: ninja-build be dropped? I changed to explicitly build with ninja (I though that was default but seems that is not the case indeed: https://src.fedoraproject.org/rpms/cmake/blob/rawhide/f/macros.cmake.in) > - The rpmlint output from fedora-review is broken for unknown reasons, so I > ran it manually. It only complains about missing man pages for the binaries. > It would be good to have an upstream issue report to request man pages. > (rpmlint hit an error when processing the debuginfo package, but I don't care > because the odds of problems there are very low.) Sure, will open an issue; all binaries seems to be well documented when you call them with --help though; is this really necessary or only a nice to have? Another round of builds: - Spec URL: https://download.copr.fedorainfracloud.org/results/jjardon/buildbox/fedora-40-x86_64/07874400-buildbox/buildbox.spec - SRPM URL: https://download.copr.fedorainfracloud.org/results/jjardon/buildbox/fedora-40-x86_64/07874400-buildbox/buildbox-1.2.12-1.fc40.src.rpm - Build: https://copr.fedorainfracloud.org/coprs/jjardon/buildbox/build/7874400/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2302674 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202302674%23c9 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
