https://bugzilla.redhat.com/show_bug.cgi?id=2295793

Fabio Valentini <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|[email protected]    |[email protected]
              Flags|                            |fedora-review?



--- Comment #7 from Fabio Valentini <[email protected]> ---
Two minor issues:

1. It looks like you changed the License tag in the package from
LGPL-2.0-or-later to LGPL-2.1-or-later.
   The latter matches the license text included in the package.

   Is this an actual issue in the crate? i.e. is LGPL-2.1-or-later the intended
license (I assume so)?
   If this is the case, please file an issue with the upstream project about
fixing the license expression in the crate metadata.

   Additionally, to have automated tools for collecting license information
pick this fix up, you will need to use "rust2rpm -p" to patch Cargo.toml for
this change too - just editing the License tag in the generated spec file is
not enough in this case.

2. You dropped the subpackage corresponding to the "test_runtime" feature. Why?
   It has no additional dependencies, so I see no reason to hide this feature
on the RPM metadata side.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2295793

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202295793%23c7

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to