https://bugzilla.redhat.com/show_bug.cgi?id=2294727

Fabio Valentini <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |fedora-review?
             Status|NEW                         |ASSIGNED
                 CC|                            |[email protected]
           Doc Type|---                         |If docs needed, set a value
           Assignee|[email protected]    |[email protected]



--- Comment #2 from Fabio Valentini <[email protected]> ---
Looks OK to me. Just please clarify some things:

- The subpackage for the "mtls" and "x509-parser" features are missing from the
package.
  Are these optional features with additional dependencies that you don't want
to package / don't need?

- Looks like some doctests can only be run inside the upstream git repository.
The doctests you are skipping result in 0 (zero) doctests remaining that are
compiled or run. In this case, it would be much, much easier to use
`%cargo_test -- --lib` instead of manually listing all source files.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2294727

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202294727%23c2

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to