https://bugzilla.redhat.com/show_bug.cgi?id=2276821



--- Comment #4 from Peter Lemenkov <[email protected]> ---
Few remarks:

* I can't build it in Koji -
https://koji.fedoraproject.org/koji/taskinfo?taskID=119423811. That's a big
issue you have to address (missing "BuildArch: noarch"?).

* Why not to package the latest version? Is there anything which prevents you
from upgrading to the latest one? 2024.06 (
https://github.com/hugsy/gef/releases/tag/2024.06 )

* Consider using %autorelease and %autochangelog macros.

* Please check if "Requires: python3" is really necessary? I cannot check since
it fails to build in Koji but I think it will be picked up automatically.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2276821

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202276821%23c4
--
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to