https://bugzilla.redhat.com/show_bug.cgi?id=2042375
--- Comment #12 from Sandro Bonazzola <[email protected]> --- Looking at the spec file, I see: BuildRequires: make BuildRequires: gcc systemd-rpm-macros But there's no need for gcc, nothing to be compiled there. There's a SystemD unit shipped in the package but it's not properly handled within the spec file. Please refer to: https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_scriptlets on how to handle SystemD units. I also think systemd should be in Requires. You can also use `%_systemd_util_dir` instead of hardcoding the systemd path in `export SYSTEMD_SERVICE_PATH=/usr/lib/systemd` Looking at the upstream code, I see calls to `sudo`, `logname`, `gpuvis`, `perf`, `trace-cmd`. Requires on their existence are missing. Looks like there's no package providing `gpuvis` command, perhaps you need to package that one as well? As it brings up a rpc service socket listening on rpcServerPort = 47317 you may want to provide a firewalld service file as well to make it easy granting access to that port. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2042375 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202042375%23c12 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
