https://bugzilla.redhat.com/show_bug.cgi?id=2141870



--- Comment #4 from Scott K Logan <[email protected]> ---
> Does it need a %license directive to store its license file?

Great question. This was actually revealed to me moderately recently, but
"modern" Python packages will install their `LICENSE` file as part of the
Python metadata if it was properly declared in the package.

This is the case for flake8-deprecated:

  $ rpm -qlp RPMS/noarch/python3-flake8-deprecated-2.0.1-2.fc39.noarch.rpm |
grep LICENSE
  /usr/lib/python3.12/site-packages/flake8_deprecated-2.0.1.dist-info/LICENSE

I can't find mention of it directly in the Python Packaging Guidelines[1], but
there is mention of a macro flag to cause a build break if the LICENSE file is
removed for whatever reason. I've updated the package to include that flag.
There have also been releases in the ~18 months it's been since I submitted
this review, so I updated the package to the latest release, 2.2.1.

Spec URL:
https://cottsay.fedorapeople.org/python-flake8-deprecated/python-flake8-deprecated.spec
SRPM URL:
https://cottsay.fedorapeople.org/python-flake8-deprecated/python-flake8-deprecated-2.2.1-1.fc41.src.rpm
Koji scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=115262591

[1]
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_build_macros


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2141870

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202141870%23c4
--
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to