Hi, On Mon, Jul 23, 2012 at 09:42:10PM +0200, Marcus Osdoba wrote: > Dear mailinglist, > > I am using lxc in a pacemaker clustered environment. > I have noted, that the current version in git is not capable to work > with 0.7.5 correctly. > > The lxc-ps command changed in 0.7.5, too. So I have applied the same > fix as the last commit on lxc in resource-agent.git [0]. > > [1] and [2] are cosmetical fixes. I think it's better to give a > warning, when the container is stopped instead of cleanly halted. > > Regarding [3], at least in Debian based systems, it's possible to > launch the lxc-halt command to perform a clean shutdown of the > container. Therfore, I enhanced the current lxc-ocf version to > support an additonal optional parameter named shutdownmethod. It > defaults to the current behaviour, which is sending SIGPWR to > init/systemd processes inside the container. Alternatively, it's > possible to command an lxc-halt to the container (which does not > require the requested powerfail-line in inittab).
Good. Though in this patch, the earlier check for setting options depending on the lxc version (0.7.5) is removed. Was that intentional? > Please consider committing [0] at least and think about the [0] has already been committed. Or did I miss something in your version of the patch? > alternative halt-method [3]. > > Thanks in advance and kind regards, Thanks for the patches! It'd be good to either send the patches to the linux-ha-dev ML or to use the github.com pull requests (preferably the former, because the patches are then readily available in the message for discussion :) Cheers, Dejan > Marcus > > > [0] > https://gitorious.org/debian/resource-agents/commit/f7b8fba8809d34c537e95a1aeaa2bc64463a9049 > > [1] > https://gitorious.org/debian/resource-agents/commit/08c321a5c92793d6b43bbffef980fdabaa1df1ce > > [2] > https://gitorious.org/debian/resource-agents/commit/42838ca854557a06ee9669cea9e1c560b5b50d46 > > [3] > https://gitorious.org/debian/resource-agents/commit/cc3bdb5968d0a28a695acc93c23a4cf1f09749f6 > > _______________________________________________ > Pacemaker mailing list: Pacemaker@oss.clusterlabs.org > http://oss.clusterlabs.org/mailman/listinfo/pacemaker > > Project Home: http://www.clusterlabs.org > Getting started: http://www.clusterlabs.org/doc/Cluster_from_Scratch.pdf > Bugs: http://bugs.clusterlabs.org _______________________________________________ Pacemaker mailing list: Pacemaker@oss.clusterlabs.org http://oss.clusterlabs.org/mailman/listinfo/pacemaker Project Home: http://www.clusterlabs.org Getting started: http://www.clusterlabs.org/doc/Cluster_from_Scratch.pdf Bugs: http://bugs.clusterlabs.org
