Version 2 attached. This version includes the suggested commit message and removes any white space changes, which should keep the patch more on topic and shorter for review.
----- Original Message ----- From: "Andrew Beekhof" <and...@beekhof.net> To: "The Pacemaker cluster resource manager" <pacemaker@oss.clusterlabs.org> Sent: Friday, April 29, 2011 3:15:08 AM Subject: Re: [Pacemaker] [patch 1/2] Prune glib from stonith api, clean paramter lists. There are some spurious whitespace changes that need to be removed and "more glib prune from API" isn't really acceptable as the commit message. <severity>: <system>: something descriptive In this case... Medium: stonith: Remove Glib data types from the API arguments This is the first step towards purging Glib from the API so that low level consumers don't need to explicitly use or link against Glib which is considered "heavy". On Thu, Apr 28, 2011 at 5:49 PM, Marcus Barrow <mbar...@redhat.com> wrote: > > This is patch 1/2 for pacemaker-devel that removes the requirement for > stonith clients to use GLIB. > > It removes the use of GLIB data types in the API arguments. The GLIB hash > tables and lists used as parameters have been replaced with a structure > describing key / value pairs. The gboolean type was replaced with a simple > bool. > > The stonith-ng header file was also split to isolate internal things from > what API users require. > > These changes were then followed thru in the stonith-test, stonith-admin and > raexecstonith programs. > > Regards, > Marcus Barrow > > _______________________________________________ > Pacemaker mailing list: Pacemaker@oss.clusterlabs.org > http://oss.clusterlabs.org/mailman/listinfo/pacemaker > > Project Home: http://www.clusterlabs.org > Getting started: http://www.clusterlabs.org/doc/Cluster_from_Scratch.pdf > Bugs: > http://developerbugs.linux-foundation.org/enter_bug.cgi?product=Pacemaker > > _______________________________________________ Pacemaker mailing list: Pacemaker@oss.clusterlabs.org http://oss.clusterlabs.org/mailman/listinfo/pacemaker Project Home: http://www.clusterlabs.org Getting started: http://www.clusterlabs.org/doc/Cluster_from_Scratch.pdf Bugs: http://developerbugs.linux-foundation.org/enter_bug.cgi?product=Pacemaker
glib-prune
Description: Binary data
_______________________________________________ Pacemaker mailing list: Pacemaker@oss.clusterlabs.org http://oss.clusterlabs.org/mailman/listinfo/pacemaker Project Home: http://www.clusterlabs.org Getting started: http://www.clusterlabs.org/doc/Cluster_from_Scratch.pdf Bugs: http://developerbugs.linux-foundation.org/enter_bug.cgi?product=Pacemaker
