Version 2. I updated to apply cleanly on top of the previous patch and provided 
the following commit message:

Medium: stonith: Allow clients to avoid use of Glib mainloop.

Allow an application to avoid use of the Glib mainloop by polling
on the asyncronous file descriptor provided in the connect call.
Activity is then handled by using the newly provided dispatch api
routine, whcih calls stonith_dispatch().




----- Original Message -----
From: "Andrew Beekhof" <and...@beekhof.net>
To: "The Pacemaker cluster resource manager" <pacemaker@oss.clusterlabs.org>
Sent: Friday, April 29, 2011 3:21:24 AM
Subject: Re: [Pacemaker] [patch 2/2] Prune glib from stonith api, don't require 
glib mainloop

Again, "glib prune mainloop stuff" just isn't good enough as a commit message.
You've gone to the effort to describe the reason for the patch below,
thats the sort of stuff that should go in the commit message.

The patch itself is good though.

On Thu, Apr 28, 2011 at 5:49 PM, Marcus Barrow <mbar...@redhat.com> wrote:
>
> This is patch 2/2 for pacemaker-devel that removes the requirement for 
> stonith clients to use GLIB.
>
> This patch removes the sync_fd paramter from the connect api call and splits 
> the dispatch api call into an internal and external version. The external 
> version does not require the paramters required for mainloop callbacks.
>
> These changes are then propagated to the stonith-test, stonith-admin and 
> other pacemaker components.
>
> Regards,
> Marcus Barrow
>
> _______________________________________________
> Pacemaker mailing list: Pacemaker@oss.clusterlabs.org
> http://oss.clusterlabs.org/mailman/listinfo/pacemaker
>
> Project Home: http://www.clusterlabs.org
> Getting started: http://www.clusterlabs.org/doc/Cluster_from_Scratch.pdf
> Bugs: 
> http://developerbugs.linux-foundation.org/enter_bug.cgi?product=Pacemaker
>
>

_______________________________________________
Pacemaker mailing list: Pacemaker@oss.clusterlabs.org
http://oss.clusterlabs.org/mailman/listinfo/pacemaker

Project Home: http://www.clusterlabs.org
Getting started: http://www.clusterlabs.org/doc/Cluster_from_Scratch.pdf
Bugs: http://developerbugs.linux-foundation.org/enter_bug.cgi?product=Pacemaker

Attachment: glib-mainloop
Description: Binary data

_______________________________________________
Pacemaker mailing list: Pacemaker@oss.clusterlabs.org
http://oss.clusterlabs.org/mailman/listinfo/pacemaker

Project Home: http://www.clusterlabs.org
Getting started: http://www.clusterlabs.org/doc/Cluster_from_Scratch.pdf
Bugs: http://developerbugs.linux-foundation.org/enter_bug.cgi?product=Pacemaker

Reply via email to