On Mon, Oct 4, 2010 at 1:18 PM, Keisuke MORI <keisuke.mori...@gmail.com> wrote: > 2010/10/2 Andreas Hofmeister <a...@collax.com>: >> Hi, >> >> it seems to me that patch >> >> http://hg.clusterlabs.org/pacemaker/stable-1.0/rev/8241f689bf9f >> >> broke timeouts for stop operations. The observable effect is that the >> timeout for stop operations is always 125s, regardless what was specified in >> the CIB. Reverting the part of the patch that changes "crmd/lrm.c" seems to >> fix the problem. >> >> The attached patch reverts the change to "crmd/lrm.c" and also >> >> http://hg.clusterlabs.org/pacemaker/stable-1.0/rev/66df1404fdcb >> >> which dealt with another side effect of the change in "crmd/lrm.c" . >> > > Hi Andreas, > > You're right and I confirmed that the problem exists > in the 1.0 tip and the problem goes away with your patch. > > > Andrew, > > Doesn't this problem exist in 1.1?
It does/did until yesterday. > Is there more changesets > that need to be backported regarding to this issues? There is now that Andreas brought the problem to my attention :-) http://hg.clusterlabs.org/pacemaker/1.1/rev/e097c70226fe > If not, I think that the Andreas' patch should be applied to 1.0. > It seems to me that the patch is sane as it would restore the old > behavior for the stop operation with having the resource attributes as > the first patch intended. See the comment in the above patch. Andreas' original patch wouldn't have worked if the resource definition changed. _______________________________________________ Pacemaker mailing list: Pacemaker@oss.clusterlabs.org http://oss.clusterlabs.org/mailman/listinfo/pacemaker Project Home: http://www.clusterlabs.org Getting started: http://www.clusterlabs.org/doc/Cluster_from_Scratch.pdf Bugs: http://developerbugs.linux-foundation.org/enter_bug.cgi?product=Pacemaker
