Hi Serge, On 05/17/2010 07:50 PM, Serge Dubrouski wrote: > I'm really sorry but please disregard that patch. The more appropriate > would be these two attached patches.
> # Validate most critical parameters
> pgsql_validate_all() {
> - if ! have_binary $SH
> + if ! check_binary $SH
> then
> return $OCF_ERR_INSTALLED
> fi
You can just do check_binary. No need for have_binary and any if test;
check_binary just exits with $OCF_ERR_INSTALLED if it doesn't find the
binary.
Wrt the $FUSER patch, is it really necessary to specify the full path to
fuser? Other RAs simply do check_binary <binary>, relying on <binary> to
be found in the $PATH.
Cheers,
Florian
signature.asc
Description: OpenPGP digital signature
_______________________________________________ Pacemaker mailing list: Pacemaker@oss.clusterlabs.org http://oss.clusterlabs.org/mailman/listinfo/pacemaker Project Home: http://www.clusterlabs.org Getting started: http://www.clusterlabs.org/doc/Cluster_from_Scratch.pdf
