and...@beekhof.net wrote on 06/30/2009 14:14:12 PM:

> I'd prefer sbin_PROGRAMS instead of halib_PROGRAMS for
> notifyServicelogEvent (the others are only installed there for legacy
> reasons).
> Also, since you're linking against crmcommon (which should be
> $(top_builddir)/lib/common/libcrmcommon.la btw), you may want to use
> the crm_err(), crm_debug() macros instead of using syslog directly.
>
> If you're happy with those two changes I'll make them and commit

As I was making the changes locally, I did notice that
notifyServicelogEvent needed
to now support --help and --version in order for help2man to work.

So I am attaching a revised patch for you here...

(See attached file: pacemaker.mark.1.patch)

Mark

Attachment: pacemaker.mark.1.patch
Description: Binary data

_______________________________________________
Pacemaker mailing list
Pacemaker@oss.clusterlabs.org
http://oss.clusterlabs.org/mailman/listinfo/pacemaker

Reply via email to