On Fri, Aug 09, 2024 at 08:23:02PM GMT, Марк Булатов via discuss wrote:
>
> Hello!
> During the static analisys was found possible mistake in the code in ovs
> version 2.10.7:
> 1) In file lib/ofp-util.c:100 -1 after shift left on 1 size can return -1,
> but function is type static uint32_t. This may cause the loop to return.
> Please correct if this is wrong.
>
What loop?
You mean in this function?
static uint32_t
version_bitmap_from_version(uint8_t ofp_version)
{
return ((ofp_version < 32 ? 1u << ofp_version : 0) - 1) << 1;
}
Thanks.
Adrián
> Please explain these place in the code and does it require any change?
> Thanks in advance.
> _______________________________________________
> discuss mailing list
> disc...@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-discuss
_______________________________________________
discuss mailing list
disc...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-discuss
