On 3/25/24 08:06, Felix Huettner wrote: >>> >>> Hi everyone, >>> >>> i have built a first version of this here and it does indeed solve our >>> issues. Not sure though if there is more. I would like to send it to >>> ovs-dev sometime next week once i added some tests. >>> In the mean time you can take a look here: >>> >>> https://github.com/openvswitch/ovs/compare/master...felixhuettner:ovs:fix_it >> >> Thanks, Felix! This is a possible route to take, however, there is >> still an issue with miniflow_extract() requesting UDP checksum offload >> not realizing that it requests it for an inner header. >> >> <rant> >> IMHO, the fact that flag can mean different things at different times >> is the root of many of the problems with offloading and we'll keep >> getting issues like this until API is fixed. >> </rant> >> >> I sent my version of the fix here: >> >> https://patchwork.ozlabs.org/project/openvswitch/patch/20240322144213.1073946-1-i.maximets%40ovn.org/ >> >> This should resolve the issue, but at a cost of dropping tunneled >> traffic when userspace-tso is enabled. >> >> Would be great if you can test it out. > > Hi Ilya, > > thanks for the fix. > It works great for me.
Thanks for testing! Best regards, Ilya Maximets. > > Thanks > Felix > >> >> The other big issue is that these crashes are happening in the default >> configuration, i.e. do not actually require users to opt-in for >> userspace-tso. >> >> Best regards, Ilya Maximets. >> _______________________________________________ discuss mailing list disc...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-discuss
