> I think, the issue should still be there, though I didn't check. > Why exactly porting of the mf_set_mask_l3_prereqs() is a problem? > do_xlate_actions() looks different in 2.5.3, but it still performs > same mf_are_prereqs_ok() check. Can't you just add the call in the > body of the if as it is done on newer versions? That's what I originally did, but I'm not sure I fully grasp the implementation enough yet.
The old implementation does mf_mask_and_prereqs() before the if whereas the new one does the if, then the fix adds the mf_set_mask_l3_prereqs() and finally it does mf_mask_field_masked(). So I was second guessing adding it inside the if as I was afraid it was already too late to do mf_set_mask_l3_prereqs(). > On the other note, do you plan to migrate to any supported version? > 2.5.3 is six years old at this point and not supported for more than > two years. I surely hope so. On our side we're following what is in XenServer, but we also contribute, so we're wondering about contributing an update as the task is from my understanding existing but not planned yet on their side. I know someone internally tried a newer version and it "didn't work". Unfortunately it was a quick test and there is no report so I don't know which version was tested. > FWIW, we removed [1] support for XenServer integration in 3.0, > because nobody was using it, so it slowly decayed and likely didn't > work anyway. > > Can be brought back, if someone is willing to support it. > 2.17 is the current LTS and it still has XenServer integration, > I'm not sure if it's working though as I have no way to test it. Thanks for the heads up, and pointing to versions and this commit, that will likely be helpful if we go ahead and try to contribute that update (I guess I'll be the most likely to do this). _______________________________________________ discuss mailing list disc...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-discuss
