Thanks! Yeah those changes are sensible, I wasn't sure what header file to use, and the printf is left over from debugging.
I guess my next question is, can anyone update the old Windows build zip at https://osmocom.org/attachments/2242 as software like SDR# pulls rtlsdr.dll from that via a bat file? I guess they should really pull from the weekly builds, but that probably complicates the bat file a little since it needs to track the latest build date and rename librtlsdr.dll to rtlsdr.dll. And secondly, how often does the rtl-sdr apt-get package on Linux get updated, and who would need to be informed for that to happen? Regards, Carl On Wed, Aug 23, 2023 at 10:42 AM Steve Markgraf <st...@steve-m.de> wrote: > Hi Carl > > On 22.08.23 04:16, Carl Laufer wrote: > > Awesome thanks! I've attached the patch file here, hopefully this works. > > I've made some additional changes to remove the compiler warnings the > > previous patch was giving too. > > I merged the commit, but changed two things: > > - Removed a printf to stdout (there are tools aquiring samples through a > pipe using rtl_sdr with '-' as filename for stdout output, this would > set them off). > > - Moved the definition of rtlsdr_check_dongle_model() to the 'tuner api' > header rtlsdr_i2c.h - although also not exactly fitting, this is better > than having in in tuner_r82xx.h. > > Now that I think of it, I probably should have put that in the commit > message... > > Regards, > Steve >
