On Fri, Apr 21, 2017 at 5:34 AM, SULLIVAN, BRYAN L <[email protected]> wrote:
> Luke, is the “and others.” required? If only one contributor has > contributed to the code for a module, “and others” seems to be superfluous. > So far, I have not seen specific guidance that this is required. > > > I am using the text recommendations on the wiki [1], and don't really have an opinion on this myself. Whichever is preferred I can implement. > Also, does the tool support the abbreviated license form? > > > Is that like rays example above. If so It can do, I just need to know text to check for. [1] https://wiki.opnfv.org/display/DEV/Contribution+Guidelines Thanks, > > Bryan Sullivan | AT&T > > > > *From:* Luke Hinds [mailto:[email protected]] > *Sent:* Thursday, April 20, 2017 7:44 AM > *To:* SULLIVAN, BRYAN L <[email protected]>; Raymond Paik < > [email protected]>; Ash Young <[email protected]>; gang chi < > [email protected]>; [email protected] > *Subject:* [infra] License checks in CI > > > > We have licence checking code staged for CI. > > > > 2017-04-20 15:27:43,197 - anteater.src.scan_tasks - INFO - Running Licence > Check on: insecure-test-repo > > 2017-04-20 15:27:43,198 - anteater.src.scan_tasks - INFO - Licence Check > passed for: /home/luke/ant_repos/insecure-python/path_traversal.py > > 2017-04-20 15:27:43,198 - anteater.src.scan_tasks - INFO - Licence Check > passed for: /home/luke/ant_repos/insecure-python/shell_true.py > > 2017-04-20 15:27:43,198 - anteater.src.scan_tasks - ERROR - No License > file within: /home/luke/ant_repos/insecure-python/tmp_path.py > > 2017-04-20 15:27:43,198 - anteater.src.scan_tasks - ERROR - No License > file within: /home/luke/ant_repos/insecure-python/shell_true2.py > > > > It will search for the complete Apache 2.0 block, but will filter out text > between: > > > > Copyright (c) 2017 <filter> and others > > > > ...As this is where an author adds unique fields, such as name, company, > email. > > > > So this will pass for a python / bash file: > > > > ############################################################ > ################## > > # Copyright (c) 2017 Donald Duck [[email protected]] and others. > > # > > # All rights reserved. This program and the accompanying materials > > # are made available under the terms of the Apache License, Version 2.0 > > # which accompanies this distribution, and is available at > > # http://www.apache.org/licenses/LICENSE-2.0 > <https://urldefense.proofpoint.com/v2/url?u=http-3A__www.apache.org_licenses_LICENSE-2D2.0&d=DwMFaQ&c=LFYZ-o9_HUMeMTSQicvjIg&r=OrbtGCluczz9awEKz9Fv7g&m=td_IzMPBW9CfmbbhyQ8uSU7I3T_ELG51PHEdqwbr1kM&s=N1xiXPMOm5ICaQPBDtznlOIFnW7Mo57U6tRjPf3wqbY&e=> > > ############################################################ > ################## > > > > So as long as someone uses the license format from the developers wiki or > by means of Justin's license script [1], it will pass the gate. Any > deviation from this, will get a -1 (when this is implemented at gate). > > > > I am planning on getting this rigged into CI during plugfest week. If > anyone is interested or wants a demo, come by and say hello. > > > > [1] https://github.com/Justin-chi/Lab/blob/master/add_license.sh > <https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_Justin-2Dchi_Lab_blob_master_add-5Flicense.sh&d=DwMFaQ&c=LFYZ-o9_HUMeMTSQicvjIg&r=OrbtGCluczz9awEKz9Fv7g&m=td_IzMPBW9CfmbbhyQ8uSU7I3T_ELG51PHEdqwbr1kM&s=f_h49j4Zz_jB2e7BAI1v7YrftRXEPupUFdAVDYWnT-E&e=> > > > > >
_______________________________________________ opnfv-tech-discuss mailing list [email protected] https://lists.opnfv.org/mailman/listinfo/opnfv-tech-discuss
