Hi Yujun,

Thanks for your feedback, I rename repo and add Apache License for itself.
It is experimental and welcome to improve.

Regards
Justin

2017-02-19 1:27 GMT+08:00 Yujun Zhang (ZTE) <[email protected]>:

> The script works great in qtip repo[1]. Thanks a lot, Justin.
>
> A few comments for improvements
>
>
>    1. add license to this script itself so people know how to contribute.
>    By default, it is proprietary.
>    2. ignore __init__.py as indicated in OPNFV contribution
>    guidelines[2]. A workaround is `git checkout **/__init__.py` after
>    processing.
>    3. use company name mapping in stackalytics[3]. I believe it covers
>    most contributors in OPNFV
>    4. rename the the repo. It is strange to fork a repo named Lab to
>    other account.
>
>
> [1]: https://gerrit.opnfv.org/gerrit/#/c/29029/
> [2]: https://wiki.opnfv.org/display/DEV/Contribution+Guidelines
> [3]: http://git.openstack.org/cgit/openstack/stackalytics/
> tree/etc/default_data.json#n23439
>
> On Fri, Feb 17, 2017 at 10:52 AM gang chi <[email protected]>
> wrote:
>
>> Hi,
>>
>> I think most of team has received mail from Ray who told me there are
>> over hundred files without License in Compass4nfv repo. I think some team
>> may have same issue with me.
>> so I share my script to generate license header for OPNFV repos.
>>
>> https://github.com/Justin-chi/Lab/blob/master/add_license.sh
>>
>> Here is result of the script: https://gerrit.opnfv.org/gerrit/#/c/28885/
>>
>> Hope it will works for you.
>>
>> Regards
>> Justin
>> _______________________________________________
>> opnfv-tech-discuss mailing list
>> [email protected]
>> https://lists.opnfv.org/mailman/listinfo/opnfv-tech-discuss
>>
> --
> Yujun Zhang
>
_______________________________________________
opnfv-tech-discuss mailing list
[email protected]
https://lists.opnfv.org/mailman/listinfo/opnfv-tech-discuss

Reply via email to