It seems like when I replied to Yujun’s emails I sent to the opnfv-tech-discuss-bounces address. Please see below my reply.
Carlos From: Carlos Goncalves Sent: 17 November 2016 10:16 To: 'dong.wenj...@zte.com.cn'; Yujun Zhang Cc: opnfv-tech-discuss-boun...@lists.opnfv.org Subject: RE: [opnfv-tech-discuss] 答复: [doctor] question on code refactoring task (DOCTOR-71) Hi Yujun, Wenjuan, I would not be against changing to Python or other language provided that it brings added value to the table, is socialized beforehand with the team and we have a deprecation time period i.e. current implemented framework becomes legacy code but still is the default one during deprecation period. Right, we have to handle multidimensional matrix. That adds a certain complexity to our tests code, but not too much, IMO, since we process each matrix element individually in functest. There are also matrix elements not supported or, potentially, incompatible at all. We can handle that in Bash or Python (or other), sure. I consider devstack a good example of a project where support of a multidimensional feature matrix is possible and easy to extend using with shell scripts (for Doctor it means installers, inspectors, notifiers, etc). It is really appreciated Wenjuan’s effort. Personally I would have expected Wenjuan to had suggested this to the team prior to start taking this new journey by herself by sharing her thoughts on DOCTOR-71 and on our weekly calls. Please note I’m not discarding the direction Wenjuan has in motion. This tests refactoring activity is a topic I’d actually like not only to discuss F2F with the team at the next Hackfest but also roll up our sleeves and hack on-site. It would be great to have as many of you as possible, particularly both of you. Carlos From: opnfv-tech-discuss-boun...@lists.opnfv.org<mailto:opnfv-tech-discuss-boun...@lists.opnfv.org> [mailto:opnfv-tech-discuss-boun...@lists.opnfv.org] On Behalf Of dong.wenj...@zte.com.cn<mailto:dong.wenj...@zte.com.cn> Sent: 17 November 2016 05:34 To: Yujun Zhang Cc: opnfv-tech-discuss-boun...@lists.opnfv.org<mailto:opnfv-tech-discuss-boun...@lists.opnfv.org>; TECH-DISCUSS OPNFV Subject: [opnfv-tech-discuss] 答复: [doctor] question on code refactoring task (DOCTOR-71) Hi All, I agree that we should discuess more about how to refactor the test script to let it become more modular, readable and maintainable. The programming languages is the first step. I propsed a framwork about the refactor the test script[1]. This is my init ideal, any comments are welcome. :) [1]https://github.com/openzero-zte/doctor_test_refactor BR. dwl Yujun Zhang <zhangyujun+...@gmail.com<mailto:zhangyujun+...@gmail.com>> 发件人: opnfv-tech-discuss-boun...@lists.opnfv.org<mailto:opnfv-tech-discuss-boun...@lists.opnfv.org> 2016-11-17 09:48 收件人 TECH-DISCUSS OPNFV <opnfv-tech-discuss@lists.opnfv.org<mailto:opnfv-tech-discuss@lists.opnfv.org>> 抄送 主题 [opnfv-tech-discuss] [doctor] question on code refactoring task (DOCTOR-71) Hi, doctors, Carlos has started code refactoring of the test script[1]. It looks good to separate common function and installer specific function into different modules and improve the readability of main script.[2][3] I just have some concerns about the future complexibility of this test script. We are going to handle a multidimensional matrix of test condition, i.e. N installers * M inspectors * K notifiers * ... I'm not sure shell script can handle it well and provide a user friendly way for debugging, profiling[4] and reporting. No intention to start another war between programming languages. But this is something we need to consider before going deep in code refactoring. [1]: https://jira.opnfv.org/browse/DOCTOR-71 [2]: https://gerrit.opnfv.org/gerrit/#/c/24395/ [3]: https://gerrit.opnfv.org/gerrit/#/c/24399/ [4]: https://jira.opnfv.org/browse/DOCTOR-72 _______________________________________________ opnfv-tech-discuss mailing list opnfv-tech-discuss@lists.opnfv.org<mailto:opnfv-tech-discuss@lists.opnfv.org> https://lists.opnfv.org/mailman/listinfo/opnfv-tech-discuss
_______________________________________________ opnfv-tech-discuss mailing list opnfv-tech-discuss@lists.opnfv.org https://lists.opnfv.org/mailman/listinfo/opnfv-tech-discuss
