On Tue, Aug 19, 2025 at 8:40 PM <[email protected]> wrote: > > From: 谢致邦 (XIE Zhibang) <[email protected]> > > Using parent_dev will cause use_f2fs() to make wrong detection. > > Signed-off-by: 谢致邦 (XIE Zhibang) <[email protected]> > --- > More than a year has passed, no progress, resend.
I'll reply, since you seem frustrated. And I don't like being ignored either. But I know nothing about f2fs here, and neither your terse description nor the code you're changing make it obvious to me what "wrong decision" it was making, or why this change fixes things for you without causing problems for someone else. For one, this code seems to not be specific to f2fs ... so what about non-f2fs? Are you breaking them? Perhaps you could elaborate and provide some explanation in the commit message? Show some examples? That would help both uneducated reviewers (like me), who might then better understand why your patch is good, and possibly even provide a "Reviewed-by"; but also there might be reviewers who better know what's going on, but are busy and don't want to spend time on inferring all of this. If such a reviewer doesn't see a good explanation, they may well just ignore it. Brian _______________________________________________ openwrt-devel mailing list [email protected] https://lists.openwrt.org/mailman/listinfo/openwrt-devel
