Thanks to everybody for the replies to my first patch. I tried to cover everything and will resend it now with git itself. Hopefully everything is fine then. It is my first time creating patches combined with mailing lists and also contributing to OpenWRT so every comment is welcome.

Nils

Am 20.10.2024 um 11:48 schrieb Bjørn Mork:
Nils Rottgardt <n.rottga...@gmail.com> writes:

diff --git a/band_steering.c b/band_steering.c
index 7fce1df..7b2ee00 100644
--- a/band_steering.c
+++ b/band_steering.c
@@ -86,13 +86,20 @@ void usteer_band_steering_perform_steer(struct
usteer_local_node *ln)
              continue;
Are you able to apply this patch?  Maybe email it to yourself and test
it before sending yet another broken patch to the list?

See also
https://docs.kernel.org/process/email-clients.html#thunderbird-gui
if you can't use an email client with sane defaults.

-        if (si->band_steering.below_snr) {
+        if (si->band_steering.below_snr)
+        {
How interested do you think most reviewers are in repeating their
feedback?


Bjørn

_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Reply via email to