On 5/29/24 16:24, Tomasz Maciej Nowak wrote:
From: Tomasz Maciej Nowak <tmn...@gmail.com>

LED subsystem has undergone changes how the function and color of LEDs
should be specified, so use that, while still keeping the old label.

Signed-off-by: Tomasz Maciej Nowak <tmn...@gmail.com>
---
  ...enable-front-panel-leds-in-TrimSlice.patch | 28 ++++++++++++++-----
  1 file changed, 21 insertions(+), 7 deletions(-)

diff --git 
a/target/linux/tegra/patches-6.6/101-ARM-dtc-tegra-enable-front-panel-leds-in-TrimSlice.patch
 
b/target/linux/tegra/patches-6.6/101-ARM-dtc-tegra-enable-front-panel-leds-in-TrimSlice.patch
index 9ec7f8b839f6..fa6d6db861f4 100644
--- 
a/target/linux/tegra/patches-6.6/101-ARM-dtc-tegra-enable-front-panel-leds-in-TrimSlice.patch
+++ 
b/target/linux/tegra/patches-6.6/101-ARM-dtc-tegra-enable-front-panel-leds-in-TrimSlice.patch
@@ -1,6 +1,14 @@
  --- a/arch/arm/boot/dts/nvidia/tegra20-trimslice.dts
  +++ b/arch/arm/boot/dts/nvidia/tegra20-trimslice.dts
-@@ -201,16 +201,17 @@
+@@ -2,6 +2,7 @@
+ /dts-v1/;
+
+ #include <dt-bindings/input/input.h>
++#include <dt-bindings/leds/common.h>
+ #include "tegra20.dtsi"
+ #include "tegra20-cpu-opp.dtsi"
+
+@@ -201,16 +202,17 @@
                        conf_ata {
                                nvidia,pins = "ata", "atc", "atd", "ate",
                                        "crtp", "dap2", "dap3", "dap4", "dta",
@@ -23,20 +31,26 @@
                                nvidia,pull = <TEGRA_PIN_PULL_NONE>;
                                nvidia,tristate = <TEGRA_PIN_DISABLE>;
                        };
-@@ -408,6 +409,20 @@
+@@ -408,6 +410,26 @@
                };
        };
-+ gpio-leds {
++      leds {
  +             compatible = "gpio-leds";
  +
-+              ds2 {
-+                      label = "trimslice:green:right";
++              led-ds2 {
++                      label = "green:right";
++                      color = <LED_COLOR_ID_GREEN>;
++                      function = LED_FUNCTION_STATUS;
++                      function-enumerator = <1>;

Normally the color, function and function-enumerator attribute will generate a label, if you set a label in addition it is useless. I think you should just remove the label property.

Maybe you have to migrate the configuration, is this led used in any UCI configuration

Hauke

_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Reply via email to