From: Rafał Miłecki <ra...@milecki.pl>

savedir is always present in the list of delta paths. It's guaranteed by
1. uci_alloc_context() which sets defaults
2. uci_set_savedir() which allows changing savedir

Calling uci_add_delta_path() with ctx->savedir argument seems to always
return UCI_ERR_DUPLICATE.

Fixes: 2b4872345ab2b ("make use of the history path feature in the cli")
Cc: Felix Fietkau <n...@openwrt.org>
Signed-off-by: Rafał Miłecki <ra...@milecki.pl>
---
 cli.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/cli.c b/cli.c
index 2fce39d..b4c4f95 100644
--- a/cli.c
+++ b/cli.c
@@ -748,7 +748,6 @@ int main(int argc, char **argv)
                                uci_add_delta_path(ctx, optarg);
                                break;
                        case 'P':
-                               uci_add_delta_path(ctx, ctx->savedir);
                                uci_set_savedir(ctx, optarg);
                                flags |= CLI_FLAG_NOCOMMIT;
                                break;
-- 
2.34.1


_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Reply via email to