On 2/5/22 19:34, DENG Qingfang wrote:
On Sun, Feb 6, 2022 at 2:23 AM Hauke Mehrtens <ha...@hauke-m.de> wrote:

On 2/5/22 19:21, Rosen Penev wrote:
On Sat, Feb 5, 2022 at 10:12 AM Hauke Mehrtens <ha...@hauke-m.de> wrote:

On 2/3/22 13:06, DENG Qingfang wrote:
Hi,

This series backports some patches from upstream to address the current
MT7530 DSA driver's problems.

Thanks.

DENG Qingfang (6):
     kernel: backport MediaTek jumbo frame support
     kernel: backport MT7530 ageing time support
     kernel: backport MT7530 VLAN fix
     kernel: backport MT7530 MDB operations
     kernel: backport MediaTek Ethernet PHY driver
     kernel: backport MT7530 IRQ support

Hi,

The last two patches are breaking the Linksys e8450 (mt7622) for me.

I am getting these errors:
Note the commentary in
https://github.com/openwrt/openwrt/commit/3f4301e123f29348b4ad87578d62b7d1f5f210c6

The message in dmesg is harmless. It just says the functionality in
this patch needs dts bindings, which were only provided for ramips.

The following error messages are a bigger problem:
--------
[    1.312943] mt7530 mdio-bus:00 lan1 (uninitialized): failed to
connect to PHY: -EINVAL

Try removing the PHY_INTERFACE_MODE_INTERNAL check in mt7531_phy_config_init,
the only place that returns -EINVAL.

Hi,

When I remove this check it works for me:
-------------------
[ 1.257277] mtk_hsdma 1b007000.dma-controller: MediaTek HSDMA driver registered
[    1.300344] mt7530 mdio-bus:00: no interrupt support
[ 1.321463] mt7530 mdio-bus:00 lan1 (uninitialized): PHY [mt7530-0:00] driver [MediaTek MT7531 PHY] (irq=POLL) [ 1.341285] mt7530 mdio-bus:00 lan2 (uninitialized): PHY [mt7530-0:01] driver [MediaTek MT7531 PHY] (irq=POLL) [ 1.361106] mt7530 mdio-bus:00 lan3 (uninitialized): PHY [mt7530-0:02] driver [MediaTek MT7531 PHY] (irq=POLL) [ 1.380935] mt7530 mdio-bus:00 lan4 (uninitialized): PHY [mt7530-0:03] driver [MediaTek MT7531 PHY] (irq=POLL) [ 1.400947] mt7530 mdio-bus:00 wan (uninitialized): PHY [mt7530-0:04] driver [MediaTek MT7531 PHY] (irq=POLL) [ 1.412626] mt7530 mdio-bus:00: configuring for fixed/2500base-x link mode
[    1.419713] DSA: tree 0 setup
[ 1.419879] mt7530 mdio-bus:00: Link is Up - 2.5Gbps/Full - flow control rx/tx
------------------------

I already pushed the revert for these two patches already.
Could you send a new patches and test them also on other platforms please.

Hauke

_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Reply via email to