On Mon, Nov 01, 2021 at 12:11:18PM -0700, Rosen Penev wrote: > On Mon, Nov 1, 2021 at 10:05 AM Hauke Mehrtens <ha...@hauke-m.de> wrote: > > > > This activates SECCOMP also on mips64 and mips64el. > > > > This was working fine in a basic test in qemu. > > > > Signed-off-by: Hauke Mehrtens <ha...@hauke-m.de> > > --- > > > > I only did very basic testing, why was this not activated in the beginning? > > > > > > config/Config-build.in | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/config/Config-build.in b/config/Config-build.in > > index a028ebfbc37a..9bef36e53ea1 100644 > > --- a/config/Config-build.in > > +++ b/config/Config-build.in > > @@ -376,7 +376,7 @@ menu "Global build settings" > > bool "Enable SECCOMP" > > select KERNEL_SECCOMP > > select PACKAGE_procd-seccomp > > - depends on (aarch64 || arm || armeb || mips || mipsel || > > i386 || powerpc || x86_64) > > + depends on (aarch64 || arm || armeb || mips || mipsel || > > mips64 || mips64el || i386 || powerpc || x86_64) > this should be changed to !arc. It's the only platform with no support.
procd also still lacks support for seccomp on ppc64 (kernel support for seccomp is present also for ppc64 though afaik). Even though we don't have any PPC64 targets atm I believe it would be better to explicitely list the supported architectures to avoid misunderstandings in future. RISC-V may also hit us in the near future which would then again need editing there (as procd seccomp also lacks support for RISC-V). Just my 2 cents... _______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
