> On Jun 2, 2021, at 11:19 AM, Stijn Tintel <st...@linux-ipv6.be> wrote:
>
> On 2/06/2021 01:10, Alexey Dobrovolskiy wrote:
>> Hi,
>>
>>>> service_triggers() {
>>>> - local script name use_dhcp
>>>> + local enable_server interface name script use_dhcp
>>>
>>> I'd rather leave the existing variables in their original order.
>>>
>>>
>> OpenWrt Submission Guidelines [0] says that entries in lists should be
>> placed in alphabetical order.
>> Or should variables be declared in the order in which they are used?
>>
>> [0] https://openwrt.org/submitting-patches#submission_guidelines
>
> This is unrelated to the change mentioned in the commit message. Ideally
> cosmetic changes like this go in an earlier, separate commit.
>
> Stijn
>
Agreed.
Style and substance shouldn't be mingled.
_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel
