While rebasing into setting bits instead of magic values,
I accidentally forgot to actually set the force bit.

Without it using the pins as GPIO-s did not actually work.

Fixes: b5c93ed ("ipq40xx: add Qualcomm QCA807x driver")

Signed-off-by: Robert Marko <robert.ma...@sartura.hr>
---
 target/linux/ipq40xx/files/drivers/net/phy/qca807x.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/target/linux/ipq40xx/files/drivers/net/phy/qca807x.c 
b/target/linux/ipq40xx/files/drivers/net/phy/qca807x.c
index 10d38d94a6..16d7a80455 100644
--- a/target/linux/ipq40xx/files/drivers/net/phy/qca807x.c
+++ b/target/linux/ipq40xx/files/drivers/net/phy/qca807x.c
@@ -356,6 +356,7 @@ static void qca807x_gpio_set(struct gpio_chip *gc, unsigned 
int offset, int valu
 
        val = phy_read_mmd(priv->phy, MDIO_MMD_AN, 
qca807x_gpio_get_reg(offset));
        val &= ~QCA807X_GPIO_FORCE_MODE_MASK;
+       val |= QCA807X_GPIO_FORCE_EN;
        val |= FIELD_PREP(QCA807X_GPIO_FORCE_MODE_MASK, value);
 
        phy_write_mmd(priv->phy, MDIO_MMD_AN, qca807x_gpio_get_reg(offset), 
val);
-- 
2.29.2


_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Reply via email to