Hi, > -----Original Message----- > From: openwrt-devel [mailto:openwrt-devel-boun...@lists.openwrt.org] > On Behalf Of Henrique de Moraes Holschuh > Sent: Montag, 1. März 2021 15:43 > To: Adrian Schmutzler <freif...@adrianschmutzler.de> > Cc: OpenWrt Development List <openwrt-devel@lists.openwrt.org> > Subject: Circular dependency due to backport from master > > Adrian, > > There's this backport in openwrt-19.07 (snapshot): > > commit 86aeac4fc98f42ac0ce7e0dcf1cb240e16b28f8f > Author: Adrian Schmutzler <freif...@adrianschmutzler.de> > AuthorDate: Fri Mar 13 16:56:53 2020 +0100 > Commit: Adrian Schmutzler <freif...@adrianschmutzler.de> > CommitDate: Wed Feb 24 18:05:02 2021 +0100 > base-files: source functions.sh in /lib/functions/system.sh The file > /lib/functions/system.sh depends on find_mtd_index() and > find_mtd_part() located in /lib/function.sh, so let's source that file. > Signed-off-by: Adrian Schmutzler <freif...@adrianschmutzler.de> > (backported from commit ae636effd24a7637cefca58a143063f395c82d05) > > > However, in openwrt-19.07, /lib/functions.sh *still* has one instance of > "source lib/functions/system.sh", because commit > 282e8173509a0907ec469d493f3bd9fed710c453 (base-files: do not source > system.sh in functions.sh) was not backported.
Thanks for reporting, I was completely unaware. I've simply reverted my patch, since I don't think it's worth messing with the dependencies further given the age of 19.07, and 21.02 implements it properly. Best Adrian > > Maybe commit 282e8173509a0907ec469d493f3bd9fed710c453 also needs to > be backported (likely with an added Fixes: > 86aeac4fc98f42ac0ce7e0dcf1cb240e16b28f8f pseudo-header) ? > > -- > Henrique de Moraes Holschuh > Analista de Projetos > Centro de Estudos e Pesquisas em Tecnologias de Redes e Operações > (Ceptro.br) > +55 11 5509-3537 R.:4023 > INOC 22548*625 > www.nic.br > > _______________________________________________ > openwrt-devel mailing list > openwrt-devel@lists.openwrt.org > https://lists.openwrt.org/mailman/listinfo/openwrt-devel
openpgp-digital-signature.asc
Description: PGP signature
_______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
