> -----Original Message----- > From: Rafał Miłecki [mailto:ra...@milecki.pl] > Sent: Dienstag, 19. Januar 2021 19:09 > To: Adrian Schmutzler <m...@adrianschmutzler.de> > Cc: 'Rafał Miłecki' <zaj...@gmail.com>; openwrt-devel@lists.openwrt.org; > nolt...@gmail.com > Subject: Re: [PATCH 2/2] bcm4908: build flashable & bootable firmware > images > > On 2021-01-19 12:32, Adrian Schmutzler wrote: > >> > cp $(KDIR)/bcm63xx-cfe/$(subst > >> _,$(comma),$(DEVICE_NAME))/cferam.000 > >> > $@-bootfs/ > >> > > >> > This will remove the additional variable by simply making the > >> > current soft rule to have matching device definition name and > >> > compatible a hard one. > >> > >> Are you still planning on adding generic COMPATIBLE variable filling > >> in the include/*.mk ? That would be nice to have I think. > > > > I'm not precisely sure what you are referring to here? > > Please check below quote: > > On 2021-01-15 16:18, Adrian Schmutzler wrote: > > Apart from that (and independent of whether you change the name or > > not), we should define a default value for this in Device/Default: > > > > SUPPORTED_DEVICES := $(subst _,$(comma),$(1)) or COMPATIBLE := > $(subst > > _,$(comma),$(1)) > > > > This will cover all current cases, and it can easily be overwritten by > > device-specific definitions where necessary.
I was referring to the Device/Default block in the _target_. However, having a global SUPPORTED_DEVICES/COMPATIBLE default is actually an interesting idea I will think about now... :-) Best Adrian
openpgp-digital-signature.asc
Description: PGP signature
_______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
