On Tue, Jan 5, 2021 at 12:20 PM Hannu Nyman <hannu.ny...@iki.fi> wrote: > > Hannu Nyman kirjoitti 5.1.2021 klo 16.34: > > Rosen Penev kirjoitti 5.1.2021 klo 0.29: > >> On Sun, Jan 3, 2021 at 10:14 PM Hannu Nyman <hannu.ny...@iki.fi> wrote: > >>> ... > >>> > >>> Please remove the patch section that removes the global IPV6 option's > >>> impact. > >>> If you remove the IPV6 logic, busybox will be compiled with IPv6 although > >>> the > >>> user has disabled it in OpenWrt menuconfig. > >> It seems the config section is not refreshed either in this patch. > >> That is, the other Config.in files. No idea how to update those. > > > > ... > > > > Or do you think that there is something else wrong reagrding the other > > defaults in Config-defaults.in in your patch? > > To me your patch looks sensible otherwise, except this IPV6 change. > > > > Yeah, now I got what you meant. I tried your patch set, and then I also run > the "refresh config " scripts. > > Your patch set is missing all the updates to the sourced Config.in files, > which changes become visible once you run the config refreshing commands. > > I got them refreshed after the first ath79 build with > > cd package/utils/busybox/config/ > ../convert_menuconfig.pl > ../../../../build_dir/target-mips_24kc_musl/busybox-default/busybox-1.33.0 > cd .. > ./convert_defaults.pl < > ../../../build_dir/target-mips_24kc_musl/busybox-default/busybox-1.33.0/.config > > Config-defaults.in That's only for one of the config files, not the others. > > > And then I edited by hand the IPv6 option in Config-defaults.in to get back > the OpenWrt speciality that deviates from busybox defaults. > I also manually added the needed quotes to source lines that the scripts > removed. > > I added your commits and my fix to my Github fork, so it is easier to see and > compare. > https://github.com/hnyman/openwrt/commits/bb1330fix > > I think that you should add the following fixes to your v2 patch series: > https://github.com/hnyman/openwrt/commit/95f54c3f4d9501a42eda7be4e3bd971a1887f8ac > > That is meant to be squashed into your main patch. Latest patch: https://github.com/neheb/openwrt/commit/139dc12498db287660bfad27b94e137afa4de9fa
I think that should be fine. > > > I will compile that into a firmware and test it. > > > > > _______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
