On Tue, Dec 15, 2020 at 9:26 PM Petr Štetiar <yn...@true.cz> wrote: > > Rosen Penev <ros...@gmail.com> [2020-12-15 19:03:55]: > > Hi, > > > The issue is with EL7. That would break the ability to compile. > > this is moot argument[1]: > > [root@9bb9a267fbb6 build]# cat /etc/redhat-release > CentOS Linux release 7.7.1908 (Core) > > [root@9bb9a267fbb6 build]# gcc --version > gcc (GCC) 8.3.1 20190311 (Red Hat 8.3.1-3) > Copyright (C) 2018 Free Software Foundation, Inc. > This is free software; see the source for copying conditions. There is NO > warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. > > > there's a clang warning to fix the GCC 4.8 issue: > > -Werror=gnu-empty-initializer . > > And what is your point? empty initializers are a GNU extension and not standard C. I don't think even C23. Fixing it makes the code more portable. >Are we supposed to handle this and possibly dozen > other corner cases in GCC 4.8 just because someone wants to use EL7 in default > setup and refuses to install and use modern toolchain? Even then, what's the > problem? You could still simply revert the commit which would make gcc6+ > requirement. > > 1. > https://github.com/openwrt/openwrt/commit/4ba8f7b1ef1e4c0607185a41c06b51928c625d8b#commitcomment-35907238 > > Cheers, > > Petr
_______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
