W dniu 10.07.2020 o 20:04, m...@adrianschmutzler.de pisze:
> Hi,
> 
>> -----Original Message-----
>> From: openwrt-devel [mailto:openwrt-devel-boun...@lists.openwrt.org]
>> On Behalf Of Tomasz Maciej Nowak
>> Sent: Freitag, 10. Juli 2020 19:35
>> To: openwrt-devel@lists.openwrt.org
>> Cc: Alexandra Alth <alexan...@alth.de>
>> Subject: [PATCH v2] mvebu: add support for MACCHIATObin Single Shot
>>
>> The currently supported Double Shot variant provides dts which is not
>> entirely compatible with Single Shot variant. The symptoms are that SFP
>> ports are not working. To remedy this, add two images to distinguish both
>> boards, wich have proper dtb assigned.
>>
>> Reported-by: Alexandra Alth <alexan...@alth.de>
>> Signed-off-by: Tomasz Maciej Nowak <tome...@o2.pl>
>> ---
>>
>> v1 -> v2
>> - Rebase onto "mvebu: fix support for Marvell 8040 MACCHIATOBin".
>> - Add missing cases for network, sysupgrade and U-Boot environment
>>   location.
>> - Fix Double Shot case in U-Boot evironment location.
> 
> thanks for updating.
> 
> Does the state of your v1 indicate that this is _not_ tested on device?

Yes, unless Alexandra or someone else will test it. But given that Alexandra 
has tested snapshot image with dtb extracted from Debian, it should work. The 
missing bits were only userspace configuration and that's irrelevant to the 
reported problem.

Alexandra, I uploaded images with proposed changes:
https://tmn505.github.io/openwrt/openwrt-mvebu-cortexa72-marvell_macchiatobin-singleshot-ext4-sdcard.img.gz
https://tmn505.github.io/openwrt/openwrt-mvebu-cortexa72-marvell_macchiatobin-singleshot-squashfs-sdcard.img.gz
https://tmn505.github.io/openwrt/openwrt-mvebu-cortexa72-marvell_macchiatobin-singleshot-initramfs-kernel.bin

Please test them. If You want to compile images Yourself, use this tree:
https://github.com/tmn505/openwrt/tree/mvebu

and please report results here.

> 
>>
>>  package/boot/uboot-envtools/files/mvebu       |  3 ++-
>>  .../base-files/etc/board.d/02_network         |  3 ++-
>>  .../base-files/lib/upgrade/platform.sh        |  9 ++++++---
>>  target/linux/mvebu/image/cortexa72.mk         | 20 +++++++++++++++++--
>>  4 files changed, 28 insertions(+), 7 deletions(-)
>>
>> diff --git a/package/boot/uboot-envtools/files/mvebu
>> b/package/boot/uboot-envtools/files/mvebu
>> index 72e2df5d1982..8ed1f87ead46 100644
>> --- a/package/boot/uboot-envtools/files/mvebu
>> +++ b/package/boot/uboot-envtools/files/mvebu
>> @@ -24,7 +24,8 @@ globalscale,espressobin|\  globalscale,espressobin-
>> emmc|\  globalscale,espressobin-v7|\  globalscale,espressobin-v7-emmc|\
>> -marvell,armada8040-mcbin)
>> +marvell,armada8040-mcbin-doubleshot|\
>> +marvell,armada8040-mcbin-singleshot)
>>      ubootenv_add_uci_config "/dev/mtd0" "0x3f0000" "0x10000"
>> "0x10000" "1"
> 
> Oh, I overlooked that part. I will move the doubleshot change to my patch.

Happens to all of us.

> 
> Best
> 
> Adrian
> 

Regards

-- 
TMN

_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Reply via email to