On 6/11/20 6:58 PM, Ian Cooper wrote: > On Thu, 11 Jun 2020 18:15:04 +0200 Hauke Mehrtens <ha...@hauke-m.de> wrote: > >> On 6/6/20 1:42 AM, Ian Cooper wrote: ..... >> >> As nothing activates GCC_LIBSSP it is always false. I think we can >> remove this, this is not used by any package in the Kconfig part as far >> as I see it and only in some Makefiles and should be removed there >> later, but should not harm. > > The approach I was taking was to try to eliminate libssp by making as > few changes as possible. Removing it here is fine, but then also requires > the removal of the libssp package in package/libs/toolchain/Makefile and > the removal of the dependency from include/package-defaults.mk as you point > out below. > > There are two additional removals that should be made: in the host build of > binutils, where the configure flag --enable-libssp can be removed in the file > toolchain/binutils/Makefile and in toolchain/gcc/common.mk to remove the > configure option to build libssp if GCC_LIBSSP is enabled. > > I left these in based on the minimal change philosophy. If you think complete > removal in this way is desirable I'll make the changes, do a bunch of test > builds and send an updated patch. > > A git grep shows three references to GCC_LIBSSP in the packages feed. >
I would prefer if it gets removed completely in one pull commit. When it is not split over multiple commits it is easier to find everything later when someone looks at these changes in some years. Hauke _______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
