write_file() returns 1/true on success; it should return 0/false when opening the file fails.
To make it more obvious that is function returns true and not 0 on success, also change its return type to bool. Signed-off-by: Matthias Schiffer <mschif...@universe-factory.net> --- ucert.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ucert.c b/ucert.c index 2ea939947d72..7de4c12711e8 100644 --- a/ucert.c +++ b/ucert.c @@ -116,13 +116,13 @@ struct cert_object { }; /* write buffer to file */ -static int write_file(const char *filename, void *buf, size_t len, bool append) { +static bool write_file(const char *filename, void *buf, size_t len, bool append) { FILE *f; size_t outlen; f = fopen(filename, append?"a":"w"); if (!f) - return 1; + return false; outlen = fwrite(buf, 1, len, f); fclose(f); -- 2.26.2 _______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel