Hi Daniel, > -----Original Message----- > From: Daniel Golle [mailto:dan...@makrotopia.org] > Sent: Montag, 24. Februar 2020 17:43 > To: Adrian Schmutzler <freif...@adrianschmutzler.de> > Cc: openwrt-devel@lists.openwrt.org; Hans Dedecker <dedec...@gmail.com>; > Jo-Philipp Wich <j...@mein.io>; Andre Valentin <avalen...@marcant.net>; Daniel > Golle <dgo...@allnet.de>; John Crispin <j...@phrozen.org>; Matthias Schiffer > <mschif...@universe-factory.net>; Steven Barth <ste...@midlink.org>; Felix > Fietkau <n...@nbd.name> > Subject: Re: [OpenWrt-Devel] [PATCH] package: use PKG_VERSION only for > upstream packages > > On Mon, Feb 24, 2020 at 05:08:18PM +0100, Adrian Schmutzler wrote: > > In the package guidelines, PKG_VERSION is supposed to be used > > as "The upstream version number that we're downloading", while > > PKG_RELEASE is referred to as "The version of this package Makefile". > > Thus, the variables in a strict interpretation provide a clear > > distinction between "their" (upstream) version in PKG_VERSION and > > "our" (local OpenWrt trunk) version in PKG_RELEASE. > > > > For local (OpenWrt-only) packages, this implies that those will only > > need PKG_RELEASE defined, while PKG_VERSION does not apply following > > a strict interpretation. While the majority of "our" packages actually > > follow that scheme, there are also some that mix both variables or have > > one of them defined but keep them at "1". > > > > This is misleading and confusing, which can be observed by the fact that > > there typically either one of the variables is never bumped or the > > choice of the variable to increase depends on the person doing the change. > > > > Consequently, this patch aims at clarifying the situation by consistently > > using only PKG_RELEASE for "our" packages. To achieve that, PKG_VERSION > > is removed there, bumping PKG_RELEASE where necessary to ensure the > > resulting package version string is bigger than before. > > Not sure, but I guess this may bring problems when people do > opkg show-upgradable > as removing PKG_VERSION may then result in the package manager > considering it a downgrade...? > > I haven't tried nor looked into it in detail though.
Thanks for your feedback. This might actually be the only big problem I see, too, and I also have not tested it yet (but I plan to do so). I do not plan to merge this fast, but rather wanted to bring this on the table for discussion (so I do not waste time on testing details in case somebody NAKs it right away). Best Adrian _______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
